Comment 3 for bug 1321017

Revision history for this message
Galen Charlton (gmc) wrote :

One immediate comment: the $org and $depth parameters still need to be fetched from @_. Minor, of course.

The patch also removes the format filter, and callers would have to be adjusted. I did some tracing back, and it looks like the only place that ultimately expects to pass a format filter (or an OU or depth filter) to ordered_records_from_metarecord is JSPAC, which is on the chopping block anyway.

So opening up the question: do we anticipate ever wanting to have any of the following methods get passed anything other than just a metarecord ID?

open-ils.search.biblio.metarecord_to_records*
open-ils.search.biblio.metarecord.mods_slim.batch.retrieve*
open-ils.search.biblio.metarecord.mods_slim.retrieve*