Comment 31 for bug 1424815

Revision history for this message
Dan Wells (dbw2) wrote :

I really appreciate the effort put into this patch. I have only given this eyeball testing, and while it appears to be basically sound as far as functioning, I feel like the design is still fundamentally upside-down. That is, we shouldn't be reparsing and breaking down HTML strings that we are already constructing on the fly, we should look for a way to treat highlighting *and* truncating as two aspects of the same operation (preparing the field for display), and do them in the same place, all at once.

As it stands, I think this design creates undue complexity and therefore would be a maintenance burden moving forward.

My two cents,
Dan