Comment 26 for bug 1501781

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Hi, Dan!

Thanks for your perseverance. I have driven this branch around the block, and it works for me, now.

I have added my signoff in collab/dyrcona/lp150178-unaccent-patron-search-signoff in the working repository.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dyrcona/lp150178-unaccent-patron-search-signoff

Since there are no tests, this will require another signoff before it can go in.

Also, I do not think that we should backport this to 2.9 and 2.8 because it introduces new dependencies on the unaccent extension and the Text::Unaccent::PurePerl module. I'm not sure about precedent, but I think we should avoid introducing new dependencies in the middle of a released series.

I will leave it targeted at those series for now so we can have a discussion on that mater.

Thanks again, Dan.