Comment 38 for bug 1501781

Revision history for this message
Jason Stephenson (jstephenson) wrote :

I've been giving this one some thought, and I decided this is a feature, not a bug fix for the following reasons:

1) Patron search works. You can find patrons with diacritics if you add the diacritic to the search. You can also find patrons without diacritics when searching without diacritics. Search being sensitive to diacritics, while inconvenient, is not a bug.

2) This branch adds new translation strings in the form of descriptions and labels for org unit settings. I don't think we should be adding translation strings in backported bug fixes because they will not be translated for the bug fix release.

3) This branch adds new org unit settings. This is not something that I think we should do for bug fixes.

4) This branch introduces a new extension into the database. This is also not something that I think we should do for bug fixes.

I think we need to have a conversation at the conference or the next developers' meeting, whichever comes first, about what constitutes a bug fix and what is an enhancement, or at minimum what will prevent a bug fix from being backported in the future. The consensus from that discussion then should go on the wiki somewhere so that we can reference it later. I, of course, am volunteering to lead this discussion and write the wiki page after the meeting.