Comment 39 for bug 1501781

Revision history for this message
Terran McCanna (tmccanna) wrote :

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address <email address hidden>.

Bug vs New Feature: I agree it should be considered a new feature - it's definitely one I'll want to promote to my libraries!

Testing Notes: I was not able to run the pgtap tests, but I referenced them and spot-checked a variety of different special characters. Since Concerto doesn't have any patrons that have diacritics in their names, I edited patron names and then searched for them - everything I tried with diacritics and with spaces worked perfectly. I tested in both the xul client and the web client.

Wish List: The only thing I tried that did not work was apostrophes. For instance, in PINES, "O'Neal" is entered as O'Neal, O Neal, and Oneal. We also have a lot of names with apostrophes in the first names such as T'Andre. If this could be added as well before being merged into master, then that would be great, but if not, it is still a wonderful new feature worth adding in even without it.