Comment 27 for bug 1706107

Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks, Kathy!

Going through each of these:

1) This was because new global JS was added to base_js.tt2, but not added to the asset list for UpUp. Specifically, the moment.js files. Branch below adds those.

2) This is likely a local offline CGI script issue.

3) I've addressed this by being more heavy-handed about which tab you're dropped into based on logged-in-ness. If logged in, you'll be forced to the Session tab, and if logged out, the Checkout tab. I think we can refine this later, but it's a logical starting point and should reduce confusion. I also rearranged the tab order, which was necessary to make this work currently. Better minds than mine can hopefully help us improve the uib-tabset code in use here.

4) I think the whole tab use as it stands could be improved by more eyes on how it's being used. uib-tabset seems ... touchy. I don't have a great fix for that. As for the menu options staying in offline mode -- those are set at page render time, not dynamically, and that's because of the hotkey code we're using. Also, in order to have used the offline interfaces, I think the user would have to have logged out, so I suspect they'd need to log in again anyway, which means a new page load and "corrected" menu links. Am I missing something there?

5) I see it to, but it's not causing a problem. I think it's something to look into, but doesn't seem to be breaking anything.