Comment 11 for bug 1724348

Here is a minimal branch for the bug as stated:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1724348_honor_default_tab_from_catalog_search

working/user/dbwells/lp1724348_honor_default_tab_from_catalog_search

There are still a few small quirks, but I didn't want those to distract from the fundamental issue, and will open separate bugs for those.

From the commit message:

The default tab selection was not being honored from catalog searches, as the search had already set $scope.record_tab, and we were honoring that value in all cases.

Instead, let's honor that value in cases where the OPAC load doesn't change our current record, which should only happen if we load the record directly to a non-opac tab, then go to the OPAC view.

To test:
1) Set any tab other than "OPAC View" as your default view in record
details.
2) Do a catalog search.
3) Select a record, and notice your default view is not set.
4) Apply patch, do the same steps, and notice the default view is now selected.

To test regression of bug #1708951:
1) In Firefox, load a record directly (e.g. /eg/opac/staff/cat/catalog/record/123).
2) Note the default view loaded.
3) Click "OPAC View".
4) Note the view does not return to your default view, but stays on the OPAC.