Comment 16 for bug 1730758

Thanks Mike!

The new patch mostly works for me except in one case.

If I edit an existing record with a null bib source and null vis_attr_vector and apply a new source, vis_attr_vector remains null.

In my testing, vis_attr_vector updates appropriately if I'm creating a new record or if I am editing a record that previously had a value in the bib source field.

Also, after running the upgrade scripts, I noticed the old, stale values did not recalculate as part of the upgrade. Should we forcibly update records that contain a bib source as we're doing with the Located URIs? I know it will make for a long-running upgrade script, but I imagine that sites already on 3.0 have incorrect values in this field for any new or edited records that need to be recalculated.