For documentation purposes: My first Google API Key I tested with was set up to be restricted by HTTP referrers, and that does not work for this feature. I had to set up a new Google API Key that was restricted by IP address instead. Adding this to the setup documentation would save future users some time. Also, it would be helpful to indicate which of the Google APIs that the code is actually using (as of right now, Google has 17 map-related APIs). I ended up enabling the four most likely ones for testing, but I doubt all of them are needed:
Maps JavaScript API
Geocoding API
Distance Matrix API
Geolocation API
For the Bootstrap OPAC, I identified a dropped END tag that was causing an Internal Server Error in the item details page. My sign off here includes a fix for that:
For documentation purposes: My first Google API Key I tested with was set up to be restricted by HTTP referrers, and that does not work for this feature. I had to set up a new Google API Key that was restricted by IP address instead. Adding this to the setup documentation would save future users some time. Also, it would be helpful to indicate which of the Google APIs that the code is actually using (as of right now, Google has 17 map-related APIs). I ended up enabling the four most likely ones for testing, but I doubt all of them are needed:
Maps JavaScript API
Geocoding API
Distance Matrix API
Geolocation API
For the Bootstrap OPAC, I identified a dropped END tag that was causing an Internal Server Error in the item details page. My sign off here includes a fix for that:
https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ mccanna/ geosort- 2021-02- 19-signoff
Also, note that in order to properly test the sorting, I applied the fix for copy table pagination here: https:/ /bugs.launchpad .net/evergreen/ +bug/1916085