This is shaping up nicely! I've just found one issue that can cause a problem with patron notifications.
The user setting opac.default_phone isn't consulted. To reproduce, edit a patron record, (99999336610, for example). Set the following:
Day phone: 888-555-1111 User Setting Default Phone Number: 888-555-2222
Perform a search and click Place hold. Enter the patron's barcode and click Submit.
The phone number that fills in the place hold form is 888-555-1111.
Remove the Day phone from the patron record.
Place another hold for the patron, no phone number fills in the form.
This is shaping up nicely! I've just found one issue that can cause a problem with patron notifications.
The user setting opac.default_phone isn't consulted. To reproduce, edit a patron record, (99999336610, for example). Set the following:
Day phone: 888-555-1111
User Setting Default Phone Number: 888-555-2222
Perform a search and click Place hold.
Enter the patron's barcode and click Submit.
The phone number that fills in the place hold form is 888-555-1111.
Remove the Day phone from the patron record.
Place another hold for the patron, no phone number fills in the form.