Comment 34 for bug 1889128

Revision history for this message
Michele Morgan (mmorgan) wrote :

Thanks Bill! And thanks to Terran for the test system.

This looks great, it fixes the majority of the issues with the staff place holds screen. I'm adding my signoff below, but will open new bugs for the following two issues:

1. When placing a suspended hold and setting an activation date, the form accepts dates in the past. The current staff catalog prevents activation dates in the past.

2. When entering a patron barcode, a carriage return or click on Submit is required to fill in the patron's info and preferencess (see discussion in comments #17 - #19). The current staff catalog fills in the patron info as soon as the barcode is entered.

My signoff branch is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1889128_signoff