Comment 8 for bug 1901932

Revision history for this message
Blake GH (bmagic) wrote :

All,

I promptly edited this code based upon the feedback.

Highlights:

- A date carry forward feature that carry's the various date columns forward based upon the difference between today's date and the create_date for asset.call_number in the dataset. Which is the default. This can be skipped with with: psql -v skip_date_carry='1' -f load_all.sql

- Expansion of special cases for certain tables: config.metabib_class, config.org_unit_setting_type, config.global_flag.

- Dropping these tables from consideration: acq.acq_lineitem_history, acq.acq_purchase_order_history, permission.perm_list

I couldn't think of a good way to deal with the timezone issue. My first thought was to check the column for timezonetz and emit the data onto the disk without the timezone (-06). It seems, though, that the dates land in the database OK. And with the date carry forward business, the result looks sound. The drawback is git churn when the dataset is upgraded through versions of Evergreen. It looks* like the files change because they were restored to your local database, then dumped out again.

On a timezone unrelated note:

Working on this may have revealed an issue with some of our config.org_unit_setting_type rows. The seed (950) doesn't appear to insert some of these rows. Whereas, the upgrade scripts do:
opac.did_you_mean.low_result_threshold
opac.did_you_mean.max_suggestions
search.symspell.keyboard_distance.weight
search.symspell.min_suggestion_use_threshold
search.symspell.pg_trgm.weight
search.symspell.soundex.weight

Therefore, the enhanced concerto set, today, includes them.

I've created a new branch, since this branch was merged already.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/blake/lp1901932_enhanced_concerto_dataset_tweak