Comment 2 for bug 1090118

Revision history for this message
dan entous (d-entous) wrote : Re: Problems encountered installing commit-msg hook

the clone method i used in step 1 above was recommended in the tutorial http://www.mediawiki.org/wiki/Git/Tutorial#Download_MediaWiki_example_extension_using_Git

the use of -o gerrit was what was recommended here http://www.mediawiki.org/wiki/Git/Workflow#Clone_the_repository in order to avoid issues with git review.

i combined the two methods and found the issue, however, if i use the ssh:// version of the url, git-review has no problem with setup.

i don't understand the issues related to having gerrit as the sole remote for the repository; i imagine someone at wikimedia does. what are the issues?

in any case, the issue with git-review seems to be with this method, parse_git_show, and testing if port is not None on line 177. the method, parse_git_show, returns (hostname, username, str(port), project_name) and so, as far as i can tell, the test on line 177 of the code will pass when no port is derived from the remote url, because None and None as a string are different and thus the scp command tries to use -P None which throws the error.