Comment 8 for bug 1090118
Revision history for this message
| dan entous (d-entous) wrote Re: Problems encountered installing commit-msg hook | #8 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
yes, it's true that the workflow documentation mentions the ssh:// version of the repo and using that url allows me to continue with using the wikimedia gerrit server with git-review, however, i still think there's a bug, different than bug 1075751.
forget about the documentation for a moment and follow the steps i mentioned. why is git-review trying to use port None?
looking at the code, lines 177-180, the port used in the scp command s/b "", but its not getting to that part of the if statement because 'None' != None; at least this is what i think is happening. anyway, i really don't know enough yet about gerrit or python so i probably don't understand this well enough yet.
the only thing that concerns me at the moment, is that you mentioned above that it's not good to check-out the repo with -o gerrit and thus have only the one git remote, gerrit. so i'm now a bit confused/concerned about why that's the recommended method in the workflow document ...