Comment 35 for bug 1393268

Reviewed: https://review.openstack.org/186063
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=13b3a9af6e6081a0e2691a758690791f5d0e17e5
Submitter: Jenkins
Branch: master

commit 13b3a9af6e6081a0e2691a758690791f5d0e17e5
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Thu Mar 12 16:06:49 2015 +0000

    Move _check_active to nova client plugin

    The method was practically identical in Instance and Server resources,
    with only difference in reported resource type as part of error message.

    Some mocks that mocked this method directly on resource object were
    modified accordingly in unit tests.

    The new `_check_active` is made to accept both Nova server objects and server
    UUIDs/strings. This will allow changing methods of server resources
    (and tests!) one-by-one.

    Added a new method `fetch_server` that tolerates intermittent failures
    when fetching a fresh server object (similar to existing `refresh_server`).

    Unit tests for `_check_active` and `fetch_server` added.

    Related-Bug: #1393268
    Change-Id: I1b63dbd9182cc8519f43ff859a408d49789263dd