Comment 4 for bug 1570908

Reviewed: https://review.openstack.org/306490
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=584efe3329143e28fdb42b5d9496977f5cdf275a
Submitter: Jenkins
Branch: master

commit 584efe3329143e28fdb42b5d9496977f5cdf275a
Author: Oleksii Chuprykov <email address hidden>
Date: Fri Apr 29 17:03:17 2016 +0300

    Fix cancel update for nova server with defined port

    This particular patch fixes a behaviour of cancel update for
    nova server with defined port, so there are no ports manageable
    by nova. We have these issues while restoring ports after rollback:
    1) We doesn't detach any ports from current server, because we
    doesn't save them to resoruce data. (we store this data after
    succesfull create of the server)
    2) Detaching an interface from current server will fail, if the server
    will be in building state, so we need to wait until server will be
    in active or in error state.
    Refresh ports list to solve problem (1).
    Wait until nova moves to active/error state to solve (2).
    A functional test to prove the fix was added. Note, that this test is
    skipped for convergence engine tests until cancel update will work
    properly in convergence mode (see bug 1533176).
    Partial-Bug: #1570908
    Change-Id: If6fd916068a425eea6dc795192f286cb5ffcb794