Comment 14 for bug 1434548

I would agree to a certain point, but at the same time there was no
direction that this patch should not be accepted and that a different way
should be taken. If it was, then it wasn't very clear.

The alternative patch had a review period of about 12 hours. If you go back
and look at when I submitted the patch which was on Mar 21st. I had my two
+1's on the 23rd, and the first patch that questioned anything different
wasn't till April 15th.

I appreciate the response to my concerns, and I just think there should be
a better way of communicating that the solution being proposed is not the
one that should be accepted and to be more direct about the wanted
modifications. I think that would have helped me a lot more than just
waiting around like I did.

On Tue, Apr 21, 2015 at 7:59 PM, Lin Hua Cheng <email address hidden>
wrote:

> This is more of an exception...
>
> Folks wanted to get the bug fixed soon to get into Kilo RC, but there is
> no patch being proposed to address the earlier feedback.
>
> fwiw, there was a review period for the alternative patch. It just got
> merged fast since folks generally agreed with the alternative - which
> was the solution as what being suggested earlier in the review.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1434548
>
> Title:
> Selecting Cancel on Settings dashboard give error
>
> Status in OpenStack Dashboard (Horizon):
> Fix Committed
>
> Bug description:
> Using the master branch, when I go into the "Settings" dashboard as a
> user and I click the "cancel" button, I get an error. This happens in
> the "User Settings" the "Change password" sections. I'm not sure what
> the correct response should be, should it push the user back the main
> page, or should it go back to the user settings page which is the
> default page. If that's the case will the user know what just
> happened if they clicked on "Cancel" when inside the "User Settings"
> page.
>
>
> I get a message (if debug is on) or a 404 page not found that looks like
> this:
>
> Page not found (404)
> Request Method: GET
> Request URL: https://XXXXX/settings/None
> Using the URLconf defined in openstack_dashboard.urls, Django tried
> these URL patterns, in this order:
> ^$ [name='splash']
> ^api/
> ^home/$ [name='user_home']
> ^i18n/js/(?P<packages>\S+?)/$ [name='jsi18n']
> ^i18n/setlang/$ [name='set_language']
> ^i18n/
> ^qunit/$ [name='qunit_tests']
> ^jasmine/(.*?)$
> ^admin/
> ^settings/ ^password/
> ^settings/ ^$ [name='index']
> ^identity/
> ^project/
> ^auth/
> ^static\/(?P<path>.*)$
> ^media\/(?P<path>.*)$
> ^500/$
> The current URL, settings/None, didn't match any of these.
> You're seeing this error because you have DEBUG = True in your Django
> settings file. Change that to False, and Django will display a standard 404
> page.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/horizon/+bug/1434548/+subscriptions
>