any idea why these lines are there ? (iiuc, they sort of mean that the automatic setting of marker colors is individually undoable (?) (correct me if i'm wrong), even if it's in the middle of a larger operation).
Could people please test this patch, (this code was introduced in r11614 to fix https://bugs.launchpad.net/inkscape/+bug/165865 , so regressions would likely be related to marker colors [and/or Undo] )
If someone knows more than I do about the DocumentUndo::maybeDone stuff, maybe take a look there ?
the following patch works:
=== modified file 'src/widgets/ stroke- style.cpp' stroke- style.cpp 2016-03-08 01:23:26 +0000 stroke- style.cpp 2016-06-16 12:54:36 +0000
--- src/widgets/
+++ src/widgets/
@@ -1303,10 +1303,6 @@
if (update) {
setMarkerCol or(marker, combo->get_loc(), SP_ITEM(object)); >getDocument( ); :done(document, SP_VERB_ DIALOG_ FILL_STROKE,
-
- SPDocument *document = desktop-
- DocumentUndo:
- _("Set marker color"));
}
} else {
any idea why these lines are there ? (iiuc, they sort of mean that the automatic setting of marker colors is individually undoable (?) (correct me if i'm wrong), even if it's in the middle of a larger operation). /bugs.launchpad .net/inkscape/ +bug/165865 , so regressions would likely be related to marker colors [and/or Undo] ) :maybeDone stuff, maybe take a look there ?
Could people please test this patch, (this code was introduced in r11614 to fix https:/
If someone knows more than I do about the DocumentUndo: