Comment 12 for bug 1449276

Revision history for this message
Mc (mc...) wrote :

the following patch works:

=== modified file 'src/widgets/stroke-style.cpp'
--- src/widgets/stroke-style.cpp 2016-03-08 01:23:26 +0000
+++ src/widgets/stroke-style.cpp 2016-06-16 12:54:36 +0000
@@ -1303,10 +1303,6 @@

             if (update) {
                 setMarkerColor(marker, combo->get_loc(), SP_ITEM(object));
-
- SPDocument *document = desktop->getDocument();
- DocumentUndo::done(document, SP_VERB_DIALOG_FILL_STROKE,
- _("Set marker color"));
             }

         } else {

any idea why these lines are there ? (iiuc, they sort of mean that the automatic setting of marker colors is individually undoable (?) (correct me if i'm wrong), even if it's in the middle of a larger operation).
Could people please test this patch, (this code was introduced in r11614 to fix https://bugs.launchpad.net/inkscape/+bug/165865 , so regressions would likely be related to marker colors [and/or Undo] )
If someone knows more than I do about the DocumentUndo::maybeDone stuff, maybe take a look there ?