Comment 5 for bug 1545668

Revision history for this message
Robin Whittle (rw-p) wrote :

Tom, I didn't see your message earlier. I tried removing the first line and got an error message from pcb_parser.cpp "unknown token "asciiheader"". Likewise when I deleted everything before "(library".
I got various errors with other attempts at editing the file which I won't list here, because it would be more meaningful for someone to try the same things with the latest version of the program running under a debugger. I have not yet been able to compile Kicad under Linux, and I don't want to try it for Windows. (I do want to use it under Windows for various reasons to do with monitors, printers and my Logitech trackball, so Linux compilation would only be for debugging.)

Dick, I noticed your patch is now part of what, to the best of my knowledge, is the main development branch:

https://github.com/KiCad/kicad-source-mirror/commit/78d0cfc1a4c131b0973f49ec1d2620d04635b69e#diff-d9bb9ec4a9d3efca2bfd0f7d502d008f

https://github.com/KiCad/kicad-source-mirror/blob/master/pcbnew/pcad2kicadpcb_plugin/s_expr_loader.cpp

I downloaded the latest nightly which presumably has this patch: kicad-product-r6566.c2fd462-x86_64.exe

With the file I attached to this bug, the error message was from dsnlexer.cpp "Expecting "(" in input/source". I tried various edits of the file and got various error messages.

The two example files I provided seem to be valid in terms of being read OK by Altium (which produced them), by Eagle, and by Kicad 2013-07-07. I think that what is going wrong would be pretty obvious under a debugger.

As best I know this patch did not fix this problem, so I changed the status of this bug report from "Fixed Released" to "In progress".

Thanks for Kicad!

 - Robin