Comment 10 for bug 362355

Revision history for this message
Thomas Herve (therve) wrote :

It looks good to me. There are some important packaging tricks, so I guess some testing is needed. Just 2 comments:

[1]
+ python_version = sys.version.split()[0].split(".")[0:2]
+ if map(int, python_version) < [2, 6]:

You can do that instead:

+ if sys.version_info[:2] < (2, 6):

[2]
+ char *smart_argv[] = {"/usr/bin/smart", "update", NULL, NULL};

The right path needs to be "/usr/share/smart/smart", as landscape-client depends only on python-smartpm which doesn't contain /usr/bin/smart.

Thanks!