Comment 15 for bug 538219

Revision history for this message
Karl Fogel (kfogel) wrote :

I agree the confirmation dialogue is user-hostile in some circumstances, but this bugfix makes that dialog come up strictly *less* often. It can only reduce the frequency with which you get the dialog, never increase it.

I kind of like the idea of considering the person in determining whether or not to present the dialog, though. Want to file a separate bug report about that? (I think this bug reports' comments aren't really the place, for the reasons given above.)

Do you find the dialog user-hostile in practice, or did you just now deliberately stimulate it to see what it looks like? I mean, it does provide some protection from uploading the wrong file (though since the "patch" label is revokable, it's debatable whether that protection is really necessary).