This should prevent this regression in the future.
However, this test doesn't pass on master because current handling of GL_BGRA format allows for this invalid combination (which is checked in the test):
internalFormat=GL_RGBA format=GL_BGRA_EXT and type=GL_UNSIGNED_BYTE
or
internalFormat=GL_BGRA_EXT format=GL_RGBA and type=GL_UNSIGNED_BYTE
So I also sent a patch to mesa-dev that improves this and make the test pass:
I just sent for review a piglit test that checks that the combination of internalFormat= GL_BGRA_ EXT, format=GL_BGRA_EXT and type=GL_ UNSIGNED_ BYTE is valid on TexImageXD and TexSubImageXD, as specified by the extension <https:/ /www.khronos. org/registry/ gles/extensions /EXT/EXT_ texture_ format_ BGRA8888. txt>:
http:// lists.freedeskt op.org/ archives/ piglit/ 2015-October/ 017535. html
This should prevent this regression in the future.
However, this test doesn't pass on master because current handling of GL_BGRA format allows for this invalid combination (which is checked in the test):
internalFormat= GL_RGBA format=GL_BGRA_EXT and type=GL_ UNSIGNED_ BYTE
or
internalFormat= GL_BGRA_ EXT format=GL_RGBA and type=GL_ UNSIGNED_ BYTE
So I also sent a patch to mesa-dev that improves this and make the test pass:
http:// lists.freedeskt op.org/ archives/ mesa-dev/ 2015-October/ 097211. html