Comment 6 for bug 1471882

Revision history for this message
Cindy O'Neill (oneilcin) wrote :

Initial review of your pull request (note you need to do a git gerrit review in stack forge/openstack). The code in monascaclient/kslicent.py needs a change. domain id and domain name are optional fields (along with project id) - see the shell.py where they are set. This should be tested as project id is above the else for username and password.

I am researching all of the valid keystone v3 options. Documentation says you can still use project id, you can use domain id, and domain name, and you can use a mixture of project id and domain id. We need to test that all of these options work with your code changes.