Comment 1 for bug 1077876

Revision history for this message
dan wendlandt (danwent) wrote :

I'm not sure this is a bug, as this was intentional.

A common practice with unit tests is to try to have tests that isolate smaller chunks of the code to validate, even if most of those scenarios are then re-tested later as sub-components of a more involved test. In this case, we have some basic tests of the API layer, so that we can tell if the API layer is working, but the DB layer is failing. This is the same pattern we did with the core plugin in JSONV2TestCase, so I'm not sure why we would not also do it for the L3 stuff.

I don't feel super strongly about this, but I suspect our dev and reviewing cycles could be used one something more urgent.

If there are scenarios tested in TestL3NatPlugin that are NOT tested in L3NatDBTestCase, adding those to the latter class to make sure we're testing the DB side as well as the API side would be good.