Comment 5 for bug 1369386

Revision history for this message
Ben Nemec (bnemec) wrote :

A few points:

1) Dropping a new dependency on distros at the very end of the cycle like this is rather unfriendly.
2) Why is this even configurable? Why not just use ipset if it's there, and don't if it's not?
3) This change is going to cause grief to every CD user out there who is installing from source, and thus can't depend on a distro to just make the dependencies magically work. This is the situation we hit in TripleO. IMHO there should have been a deprecation period before a breaking change like this was made, so there was at least a _chance_ of it not being an unpleasant surprise.

I note that timing concerns were raised on the original review, and I disagree with the idea that there is going to be any "wider early testing" of this right now. There's nothing "early" about Juno at this point. It's late enough in the cycle that the chances of finding and fixing anything but blatantly obvious bugs with this new feature before release are slim to none.