AsyncProcess.stop() method has now additional parameter
kill_timeout. If this is set to some value different than
None, eventlet.green.subprocess.Popen.wait() will be called
with this timeout, so TimeoutExpired exception will be raised
in case if process will not be killed for this "kill_timeout"
time.
In such case process will be killed "again" with SIGKILL signal
to make sure that it is gone.
This should fix problem with failing fullstack tests, when
ovs_agent process is sometimes not killed and test timeout was
reached in this wait() method.
Reviewed: https:/ /review. openstack. org/618024 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=9b23abbdb68 f7e0c80c305ec18 74281f6dea7e9e
Committed: https:/
Submitter: Zuul
Branch: master
commit 9b23abbdb68f7e0 c80c305ec187428 1f6dea7e9e
Author: Slawek Kaplonski <email address hidden>
Date: Wed Nov 14 21:31:04 2018 +0100
Add kill_timeout to AsyncProcess
AsyncProces s.stop( ) method has now additional parameter green.subproces s.Popen. wait() will be called
kill_timeout. If this is set to some value different than
None, eventlet.
with this timeout, so TimeoutExpired exception will be raised
in case if process will not be killed for this "kill_timeout"
time.
In such case process will be killed "again" with SIGKILL signal
to make sure that it is gone.
This should fix problem with failing fullstack tests, when
ovs_agent process is sometimes not killed and test timeout was
reached in this wait() method.
Change-Id: I1e12255e5e142c 395adf4e67be9d9 da0f7a3d4fd
Closes-Bug: #1798472