In ssh_execute methon in nova/utils there was a problem with cmd passed to it.
From SanISCSIDriver and all other places it is called from cmd is a string.
But in ssh_execute method cmd was processed as a list. This can make problems
with SanISCSIdriver using.
Also it may be useful to pass execute parameter to this SanISCSIDriver class
to have the opportunity of overriding _execute method (as it is in
VolumeDriver class, that is the root of this class hierarchy). That's why
special checking was added.
Reviewed: https:/ /review. openstack. org/14491 github. com/openstack/ nova/commit/ cb9b36c94ba1652 cf60e45ae1d96ba 7bd41e5710
Committed: http://
Submitter: Jenkins
Branch: master
commit cb9b36c94ba1652 cf60e45ae1d96ba 7bd41e5710
Author: Yuriy Taraday <email address hidden>
Date: Tue Aug 28 19:57:54 2012 +0400
SanISCSIDriver SSH execution fixes.
In ssh_execute methon in nova/utils there was a problem with cmd passed to it.
From SanISCSIDriver and all other places it is called from cmd is a string.
But in ssh_execute method cmd was processed as a list. This can make problems
with SanISCSIdriver using.
Also it may be useful to pass execute parameter to this SanISCSIDriver class
to have the opportunity of overriding _execute method (as it is in
VolumeDriver class, that is the root of this class hierarchy). That's why
special checking was added.
Fixes bug 1070489
Change-Id: I73f74f9d095a2c 4316cab88148afe 6a0bde44c5b