There are comments for quota inconsistency in function
_complete_deletion and considering race conditions.
_complete_deletion was called by _complete_partial_deletion
and_delete_instance only if the instance state is DELETED
compute can enter _complete_partial_deletion
while if _complete_deletion called in _delete_instance,
that means instance vm state already become DELETED
also, if the _delete_instance was called with instance
state SOFT_DELETED, the quotas.rollback() will be called
it will make quotas.commit later take no effect
since the quotas.reservations is already None
so there is no race conditions and the comments can be removed
Reviewed: https:/ /review. openstack. org/90280 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=29f2953edf2 dc95569d53433d7 c28251f652f8d4
Committed: https:/
Submitter: Jenkins
Branch: master
commit 29f2953edf2dc95 569d53433d7c282 51f652f8d4
Author: jichenjc <email address hidden>
Date: Wed Apr 23 06:17:02 2014 +0800
Remove comments and to-do for quota inconsistency
There are comments for quota inconsistency in function deletion and considering race conditions.
_complete_
_complete_ deletion was called by _complete_ partial_ deletion delete_ instance only if the instance state is DELETED partial_ deletion
and_
compute can enter _complete_
while if _complete_deletion called in _delete_instance,
that means instance vm state already become DELETED
also, if the _delete_instance was called with instance
state SOFT_DELETED, the quotas.rollback() will be called
it will make quotas.commit later take no effect
since the quotas.reservations is already None
so there is no race conditions and the comments can be removed
Change-Id: Iddb9e5197ca7ca 9bd4692d63bb5c7 f9a2ab44be5
Partial-Bug: #1296414