Comment 12 for bug 1296414

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/93374
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1b35a3b263f47558e2e7791e27810741881eea43
Submitter: Jenkins
Branch: master

commit 1b35a3b263f47558e2e7791e27810741881eea43
Author: jichenjc <email address hidden>
Date: Mon May 12 20:27:43 2014 +0800

    Change the comments of SOFT_DELETED race condition

    _reclaim_queued_deletes will only find instances in SOFT_DELETED
    state and delete them if they are only old enough. The quotas will be
    committed when the instance was soft-deleted so that resource can
    be used right after the soft-delete operation.

    There are some concern about the quota inconsistency for the operation,
    The only case that the quota might be inconsistent is
    the compute node died between set instance state to SOFT_DELETED
    and quota commit to DB; when compute node start again
    it will have no idea the reservation is committed or not or even
    expired, since it's a rare case, so marked as todo.

    There are some alternatives if the problem need to be fixed, e.g.
    able to find reservation when nova compute restart, so we can double
    check whether the quota is committed or not.

    Partial-Bug: #1296414

    Change-Id: Idf9c179b2dd439462a646568ffd5098cd5d7851f