Comment 6 for bug 1660878

Reviewed: https://review.openstack.org/427782
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=466769e588dc44d11987430b54ca1bd7188abffb
Submitter: Jenkins
Branch: master

commit 466769e588dc44d11987430b54ca1bd7188abffb
Author: Dan Smith <email address hidden>
Date: Wed Feb 1 07:58:25 2017 -0800

    Remove pre-cellsv2 short circuit in instance get

    This removes a couple short circuits around instance cell mapping,
    which were in place for pre-cellsv2 code. Now, they defeat some of
    our atomic logic around what should be done in and around deletes.
    These were TODOs to remove once people had to be on cellsv2, which
    is now the case.

    Note that the api samples tests were depending on these in order to
    work at all (which is a good demonstration of why they need to
    be removed). This patch also extends the SingleCellSimple fixture
    with a couple more mocks to make them happily take the same path
    as the rest of the code. Since the default in that fixture is
    now to make instances look mapped all the time, we also need a flag
    so the tests that check for yet-to-be-mapped instances can still
    function.

    Related-Bug: #1660878
    Change-Id: I7eb4b41fd2f33e8a63e329adbafc47d149e31552