commit 563c0927d14d052e3f1fad80df95fe4a7c48d38b
Author: Matt Riedemann <email address hidden>
Date: Tue Jun 6 14:08:37 2017 -0400
libvirt: Check if domain is persistent before detaching devices
Previously the libvirt driver would always assume that it was only
detaching devices (volumes or virtual interfaces) from a persistent
domain however that is not always the case.
For example when rolling back from a live migration an attempt is made
to detach volumes from the transient destination domain that is being
cleaned up. This attempt would fail with the previous assumption of the
domain being persistent in place.
This change introduces a simple call to has_persistent_configuration
within detach_device_with_retry to confirm the state of the domain
before attempting to detach.
Reviewed: https:/ /review. openstack. org/441204 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=563c0927d14 d052e3f1fad80df 95fe4a7c48d38b
Committed: https:/
Submitter: Jenkins
Branch: master
commit 563c0927d14d052 e3f1fad80df95fe 4a7c48d38b
Author: Matt Riedemann <email address hidden>
Date: Tue Jun 6 14:08:37 2017 -0400
libvirt: Check if domain is persistent before detaching devices
Previously the libvirt driver would always assume that it was only
detaching devices (volumes or virtual interfaces) from a persistent
domain however that is not always the case.
For example when rolling back from a live migration an attempt is made
to detach volumes from the transient destination domain that is being
cleaned up. This attempt would fail with the previous assumption of the
domain being persistent in place.
This change introduces a simple call to has_persistent_ configuration device_ with_retry to confirm the state of the domain
within detach_
before attempting to detach.
Closes-Bug: #1669857 5f54dbe50d4455f d47d422164b
Closes-Bug: #1696125
Change-Id: I95948721a0119f