Comment 58 for bug 1366421

Revision history for this message
marmuta (marmuta) wrote :

> Fantastic. Now the onboard behavior is deterministic. I fed in 201/200 along
> with "auto-hide on key-press disabled" and everything is working perfect now.
> Please see logs below.
Yep, much better, that's how it was supposed to look, great.

The one issue that's left is, that Onboard doesn't know in which state it is in the beginning, only after the first switch occurs. There's not much I can do, unless somehow a sysfs path with that information appears. The code checks the two paths I know, but they are not supported by ideapad-laptop driver. I could easily add another one, though, in case anything changes.

> I picked revision 2216 to test if it fixes the blacklist problem.
> But it throws an exception.
Yes, I split two changes up into separate commits that weren't totally self-contained. rev. 2217 came right after and should have fixed that particular exception. I'm still working on some issues with auto-show and firefox, so there might be more shakiness in the immediate future. I hope to iron those out before the release next month.

Btw., I realized blacklisting tablet-mode keys for auto-hide on keypress may not be enough in your case. There's still that ± key being sent along with global key press 201. Maybe I have to restrict auto-hide to alpha-numeric keys and modifiers or something. Or somehow decide which source devices are "real" keyboards, if that is possible. Not sure yet. So, you probably have to keep "Hide when typing on a physical keyboard" off for a bit longer.