Comment 14 for bug 784339

Revision history for this message
jlinkels (jlinkels) wrote :

Stefan,

I think there is some confusion.

I have noticed that
(a) the balance sheet is wrong by not displaying the correct balances (https://bugs.launchpad.net/bugs/930283)
(b) the P/L sheet is wrong by not processing the sign of expense/income accounts (https://bugs.launchpad.net/bugs/930739)

THIS thread we are posting in now describes bug (b) taking abs() values in the P/L sheet.
As it seems, your patch is for solving bug (a)

Applying your patch aborts with an error message (unexpected EOF) but I think it is only the lines with the '-' and '+' character in front, and the rest is just context, right?

Let me have a look in the account_profit_loss.py if this issue is solved. As far as I have seen, the issue is still under discussion.

BTW, just to be sure, I have checked two other accounting programs (SQL-ledger and xTuple Postbooks), and both handle a negative amount on an expense account correctly (and a negative balance on the balance sheet, that is). So I think there is little doubt about what the correct processing and display should be.

jlinkels