Comment 25 for bug 921442

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

The fix for the first part of the bug report was merged in 6.0 and 6.1 at revision [1][2], updating status accordingly.

Concerning the second part of the bug report that is mostly unrelated, it is still not reproducible. All the described methods to reproduce do not seem to produce errors, except when directly injecting the error in the code of OpenERP itself, which does not prove it can happen with a normal e-mail. As a result, I'm afraid the proposed patch will not fix what it claims.
In addition, that patch is wrong for several reasons, discussed in the review of the [3] branch. Encoding issues are sometimes complex and if you jump too quickly to conclusions you risk breaking something else that is more important than the corner case you are trying to correct.

Perhaps the best way to make sure we properly fix that second part is to send us the source of a real email file that triggers the problem, as you seem to have seen one. You can safely anonymize the content of the email you manage to do it. Otherwise you can e-mail it to me (as an attachment) and I will see how we can make a proper patch. It might also make sense to handle this in a separate bug report.

For further discussion on the actual patch, do not hesitate to comment on [3].

Thanks,

[1] 6.0 rev. 5075 rev-id: <email address hidden>
[2] 6.1 rev. 6679 rev-id: <email address hidden>
[3] lp:~openerp-dev/openobject-addons/trunk-bug-921442-nco