Cannot set branch associated to a product series

Bug #31308 reported by David Allouche
30
Affects Status Importance Assigned to Milestone
Launchpad itself
Invalid
Critical
Unassigned

Bug Description

It's currently not possible to set the branch associated to a productseries.

Historically, ProductSeries.branch was set (was it?) by Importd when creating the branch for a RCS import. This functionality will be restored during the first stage of the transition of Importd to bzr.

However, it should be possible to manually set ProductSeries.branch from the web UI, regardless of RCS imports.

Related to bug 55649, they both help "bzr branch lp://...".

Revision history for this message
David Allouche (ddaa) wrote :

 Two use cases:

 * Martin is the author of bzr which always used bzr for its own version control. The ProductSeries.branch was never set by Importd and needs to be set to the existing mainline branch registered in Launchpad.
 * Michael maintains gnome-app-installer which was previously hosted on CVS but is now developed using bzr. The ProductSeries.branch is set to the RCS import branch but must be set to the native bzr branch.

Revision history for this message
David Allouche (ddaa) wrote :

Actually, Michael's use case is complicated by the fact that Importd is in transition and that the association between the productseries and the RCS import branch will be created after he manually set the ProductSeries.branch.

Generally, it's not clear what Impord should do when publishing a RCS import branch if the ProductSeries.branch is already set.

I think the proper fix would involve moving RCS import things out of ProductSeries and into a new RcsImport table. The association with other tables is not clear yet, I tried writing them down here but that turned complicated enough to suggest something was wrong.

That would allow doing RCS imports without imposing an association to a ProductSeries.

Revision history for this message
David Allouche (ddaa) wrote :

Some new interesting developments.

Setting ProductSeries.branch will cause the productseries page to oops: OOPS-44A491.

Michael actually requested to keep the RCS import running and have it published, but make it no longer part of the "main branch". He was actually meaning "main productseries". I interpret that as a direct request to separate the rcs import from the productseries.

Revision history for this message
David Allouche (ddaa) wrote :

Also, daf asked me if "cannot set branch associated to a productseries" means the "the UI doesn't support it" or "it's a permission problem".

The answer is "the UI does not support it".

David Allouche (ddaa)
Changed in launchpad:
assignee: nobody → ddaa
David Allouche (ddaa)
Changed in launchpad:
status: Unconfirmed → Confirmed
David Allouche (ddaa)
Changed in launchpad:
assignee: ddaa → nobody
Changed in launchpad-bazaar:
status: Unconfirmed → Confirmed
Revision history for this message
David Allouche (ddaa) wrote :

Rejecting launchpad bug report. The canonical bug report is now launchpad-bazaar. I did not realise that you can move bug reports across products.

Changed in launchpad:
status: Confirmed → Rejected
Revision history for this message
David Allouche (ddaa) wrote :

Discussed this issue with Robert in Vilnius, and he verbally accepted writing a specification to nail down all the desired transitions and undesired failure modes. In short, there are three valid states for a product series: no branch, native bzr, vcs import set.

Changed in launchpad-bazaar:
assignee: nobody → lifeless
David Allouche (ddaa)
description: updated
Revision history for this message
David Allouche (ddaa) wrote :

Discussion about how to fix that is in progress on the launchpad mailing list.

Changed in launchpad-bazaar:
assignee: lifeless → ddaa
Revision history for this message
James Henstridge (jamesh) wrote :

Assigning to me, based on discussion at the last Launchpad/Bazaar meeting.

Changed in launchpad-bazaar:
assignee: ddaa → jamesh
Revision history for this message
James Henstridge (jamesh) wrote :

A fix is in the review queue now. The branch separates out the idea of the "VCS import branch for this product series" from "the branch for this product series".

The VCS imports system is responsible for the former while the product owner is responsible for the latter. If the branch for the product series has not been set, then the UI displays the VCS imports branch as the series branch.

Changed in launchpad-bazaar:
status: Confirmed → In Progress
Revision history for this message
James Henstridge (jamesh) wrote :

Fix merged as r4028

We should be able to test it out on https://staging.launchpad.net in a few days.

Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Revision history for this message
James Henstridge (jamesh) wrote :

This change was included in today's rollout.

Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.