vcs-imports needs tests

Bug #42928 reported by David Allouche
24
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
David Allouche

Bug Description

vcs-imports tasks have a chronic regression problem.

We need a single story that exercises all the tasks that a vcs-imports member needs to be able to do. That includes:

* Owner (w/o special privs) and vcs-imports must be allowed to clear RCS details if the importstatus is AUTOTEST or TESTFAILED (bug 3233).

* vcs-imports must be allowed to edit RCS details (+source and +sourceadmin) regardless of importstatus (bug 31307).

* +sourceadmin must provide provide proper importstatus control (bug 31444). The requirements may need to be reconsidered since the vcs import workflow should be simplified in the future.

Maybe more use cases as I can think of them...

Tags: lp-code
David Allouche (ddaa)
Changed in launchpad:
status: Unconfirmed → Confirmed
David Allouche (ddaa)
description: updated
David Allouche (ddaa)
Changed in launchpad:
assignee: nobody → ddaa
Revision history for this message
David Allouche (ddaa) wrote :

The test story should cover bug 43119.

David Allouche (ddaa)
Changed in launchpad-bazaar:
importance: High → Critical
Revision history for this message
David Allouche (ddaa) wrote :

And bug 46240 too.

David Allouche (ddaa)
Changed in launchpad-bazaar:
importance: Critical → High
Revision history for this message
Diogo Matsubara (matsubara) wrote :

In series/+source, if you uncheck all radio buttons (using the WebDeveloper extension for firefox) and submit the form, it'll crash.

module canonical.launchpad.browser.productseries, line 371, in editSource
raise NotImplementedError, 'Unknown RCS %s' % rcstype

OOPS-245D203

Revision history for this message
David Allouche (ddaa) wrote :

Well, hu, then don't uncheck all radio buttons using the WebDeveloper extension?

David Allouche (ddaa)
Changed in launchpad-bazaar:
importance: High → Medium
Revision history for this message
James Henstridge (jamesh) wrote :

The branch I put up for review allows unsetting the revision control details (without use of WebDeveloper extension and without OOPS's).

Revision history for this message
David Allouche (ddaa) wrote :

Closing this bug as jamesh rewrite of the +source form has addressed most of the issues.

Changed in launchpad-bazaar:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.