Launchpad itself

Edit buttons on other people's page should not be visisble

Bug #3293 reported by wouter bolsterlee
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Gabriel Neuman

Bug Description

The "edit" buttons (details, homepage, hackergotchi, ssh keys, gpg keys, etc...) on other people's pages (/people/their-name) are visible while they should not.

Revision history for this message
wouter bolsterlee (wbolster) wrote :

Forgot to mention that the actual pages they link show a "permission denied" message, which is, of course, correct.

Revision history for this message
Dafydd Harries (daf) wrote :

Indeed, you shouldn't be invited to do things that you can't do.

Changed in launchpad:
status: New → Accepted
Gabriel Neuman (gabrielneuman)
Changed in launchpad:
assignee: nobody → gabrielneuman
Revision history for this message
Gabriel Neuman (gabrielneuman) wrote :

I was thinking about a trivial fix like:
@enabled_with_permission('launchpad.Edit')
for these links.
SteveA, mpt, do you think this is appropriate?
Perhalps there is a more generic or elegant solution.

Changed in launchpad:
status: Confirmed → Needs Info
Gabriel Neuman (gabrielneuman)
Changed in launchpad:
status: Needs Info → Confirmed
Dafydd Harries (daf)
Changed in launchpad:
status: Confirmed → Fix Committed
Dafydd Harries (daf)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.