Comment 2 for bug 973260
Revision history for this message
| Kapil Thangavelu (hazmat) wrote Re: [Bug 973260] Re: Unable to deploy charm that uses symbolic links from the charm store | #2 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Excerpts from Clint Byrum's message of 2012-04-04 17:39:07 UTC:
> Excerpts from William Reade's message of Wed Apr 04 12:33:05 UTC 2012:
> > ** Changed in: juju
> > Status: In Progress => Fix Released
> >
>
> William, could you perhaps document the commit that fixed this, and
> provide a brief synopsis? Thanks!
>
-------
revno: 511 [merge]
author: William Reade <email address hidden>
committer: William Reade <email address hidden>
branch nick: juju
timestamp: Wed 2012-04-04 14:29:56 +0200
message:
When extracting charms, use only filetype mode bits to detect symlinkicity
We had been writing, and checking for, a magic value (in external_attr)
which happened to equal `(stat.S_IFLNK | 0755) << 16`; the charm store was
giving us one equal to `(stat.S_IFLNK | 0777) << 16`, and we weren't
considering that to be a symlink. We now just check the filetype and ignore
permissions on symlinks.
R=hazmat
CC=
https:/
modified:
juju/
juju/
juju/
juju/