Comment 11 for bug 1523384

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

@Daniel, I'm uncomfortable with the change to the review tools to follow symlinks. They are always run on the non-target system so following the symlink would have succeeded on the developers machine, possibly in the store's environment but likely not on the target machine. The review tools do already have a test to see if symlinks are pointing outside of the app's area (check_external_symlinks() in cr_lint.py). Perhaps there is a bug in there?