reconstructor: log more details when rebuild fails
When the reconstructor fails to gather enough fragments to rebuild a
missing fragment, log more details about the responses that it *did*
get:
- log total number of ok responses, as well as the number of useful
responses, to reveal if, for example, there might have been
duplicate frag indexes or mixed etags.
- log the mix of error status codes received to reveal if, for
example, they were all 404s.
Also refactor reconstruct_fa to track all state related to a timestamp
in a small data encapsulation class rather than in multiple dicts.
Reviewed: https:/ /review. opendev. org/c/openstack /swift/ +/787279 /opendev. org/openstack/ swift/commit/ 7960097f02bab5a 4568eddb6b98d7b 8b47543561
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 7960097f02bab5a 4568eddb6b98d7b 8b47543561
Author: Alistair Coles <email address hidden>
Date: Tue Apr 20 19:14:19 2021 +0100
reconstructor: log more details when rebuild fails
When the reconstructor fails to gather enough fragments to rebuild a
missing fragment, log more details about the responses that it *did*
get:
- log total number of ok responses, as well as the number of useful
responses, to reveal if, for example, there might have been
duplicate frag indexes or mixed etags.
- log the mix of error status codes received to reveal if, for
example, they were all 404s.
Also refactor reconstruct_fa to track all state related to a timestamp
in a small data encapsulation class rather than in multiple dicts.
Related-Bug: 1655608 775ce59f3724f17 d5db948d502
Change-Id: I3f87933f788685