Reviewed: https://review.opendev.org/687999 Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=e64c78dcf720202a0542bb1e1184f5229a11524f Submitter: Zuul Branch: master
commit e64c78dcf720202a0542bb1e1184f5229a11524f Author: Ghanshyam Mann <email address hidden> Date: Thu Oct 10 22:26:43 2019 +0000
Add workaround to handle the testtool skip exception in CLI test
This commit apply the workaround for testtool skip exception in CLI test base class. - https://review.opendev.org/#/c/681340/6
I have modified the workaround done in above commit to more generic one.
We are good on skipException from test code. That is handled by teststools.TestCase's self.exception_handlers - https://github.com/testing-cabal/testtools/blob/f51ce5f934153e80d3e8a95b52e1464daeb30c14/testtools/testcase.py#L275 Mapped handler _report_skip() will add the respective tests to skip list
Current CLI test failure -https://zuul.opendev.org/t/openstack/build/c1bb61121e1d4d108c52adad200e8991/log/job-output.txt#6354
I have tested both test.BaseTestCase and lib.base.BaseTestCase with all 8 combinations of below: - py >= 3.5 and py < 3.5 (on py2.7) - stestr >= 2.50 and stestr < 2.5.0 - skip exception from setUpClass and skip exception from test code
Closes-Bug: 1847749
Change-Id: Ib70bdffaf4d38743e7cbbeb88af51bb57ceeedf6
Reviewed: https:/ /review. opendev. org/687999 /git.openstack. org/cgit/ openstack/ tempest/ commit/ ?id=e64c78dcf72 0202a0542bb1e11 84f5229a11524f
Committed: https:/
Submitter: Zuul
Branch: master
commit e64c78dcf720202 a0542bb1e1184f5 229a11524f
Author: Ghanshyam Mann <email address hidden>
Date: Thu Oct 10 22:26:43 2019 +0000
Add workaround to handle the testtool skip exception in CLI test
This commit apply the workaround for testtool skip exception /review. opendev. org/#/c/ 681340/ 6
in CLI test base class.
- https:/
I have modified the workaround done in above commit to more generic
one.
We are good on skipException from test code. That is handled by TestCase' s self.exception_ handlers /github. com/testing- cabal/testtools /blob/f51ce5f93 4153e80d3e8a95b 52e1464daeb30c1 4/testtools/ testcase. py#L275
teststools.
- https:/
Mapped handler _report_skip() will add the respective tests to skip list
Current CLI test failure /zuul.opendev. org/t/openstack /build/ c1bb61121e1d4d1 08c52adad200e89 91/log/ job-output. txt#6354
-https:/
I have tested both test.BaseTestCase and lib.base. BaseTestCase with all 8 combinations
of below:
- py >= 3.5 and py < 3.5 (on py2.7)
- stestr >= 2.50 and stestr < 2.5.0
- skip exception from setUpClass and skip exception from test code
Closes-Bug: 1847749
Change-Id: Ib70bdffaf4d387 43e7cbbeb88af51 bb57ceeedf6