Comment 3 for bug 1324598

Revision history for this message
Andrea Rosa (andrea-rosa-m) wrote :

Clint, thanks for the review.
You are right that the escape problem is solved by os-apply-config but the problem about comments which are not rendered is still there.
As you can see from your test the comment is not rendered at all.
I moved, in the fix, the comment before each option so as we can specify a comment at key level, that is what is done in other templates for other images, like for example for the keystone template (tripleo-image-elements/elements/keystone/os-apply-config/etc/keystone/keystone.conf)

If you agree I'd leave in the patch the triple braces as that doesn't harm and it seems to me more clear and more close to the mustache syntax.
Do you agree with me?

If so I'll amend the description of the bug.

Thanks
--
Andrea