Comment 6 for bug 1032390

Revision history for this message
Micah Gersten (micahg) wrote :

A few comments.
debian/control:
Shouldn't the short description say bindings instead of extension?
The long description shouldn't mention Ubuntu as Unity is its own thing.

debian/watch:
Is CPAN the official place to download binaries, or is Launchpad? I would think a Launchpad https URL is preferable to a CPAN URL unless there's some other form of easy verification that the download is authentic.

debian/patches/fix_manpage_line_break:
would be nice if this had a link to a bug that has it reported upstream (not a blocker)

Otherwise, +1 from me.
The only change this needs to build in unstable is a build dependency on xauth (our xvfb package Depends on it whereas in Debian it's a Recommends). I'd love to see this go straight to Debian rather than to Ubuntu (or at least uploaded to both initially and sync'd as soon as possible).