Comment 7 for bug 1032390

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote : Re: [Bug 1032390] Re: [needs-packaging] libgtk2-appindicator-perl

Thanks for the review!

On Mon, Aug 6, 2012 at 1:01 AM, Micah Gersten
<email address hidden> wrote:
> A few comments.
> debian/control:
> Shouldn't the short description say bindings instead of extension?
> The long description shouldn't mention Ubuntu as Unity is its own thing.

Fixed.

> debian/watch:
> Is CPAN the official place to download binaries, or is Launchpad? I would think a Launchpad https URL is preferable to a CPAN URL unless there's some other form of easy verification that the download is authentic.

Makes sense. Fixed as well.

> debian/patches/fix_manpage_line_break:
> would be nice if this had a link to a bug that has it reported upstream (not a blocker)

https://bugs.launchpad.net/libgtk2-appindicator-perl/+bug/1033655

> Otherwise, +1 from me.
> The only change this needs to build in unstable is a build dependency on xauth (our xvfb package Depends on it whereas in Debian it's a Recommends). I'd love to see this go straight to Debian rather than to Ubuntu (or at least uploaded to both initially and sync'd as soon as possible).

I'm going to go ahead and upload it to Ubuntu first as Debian is in
freeze, so I doubt it will be a priority for any of my potential
sponsors. I'm already on the pkg-ayatana team. That should be a good
home for it. I'll file an ITP and push a branch to the team's Alioth
repository.

Thanks again,

-- Andrew Starr-Bochicchio

   Ubuntu Developer <https://launchpad.net/~andrewsomething>
   Debian Maintainer
<http://qa.debian.org/developer.php?login=a.starr.b%40gmail.com>
   PGP/GPG Key ID: D53FDCB1