Comment 8 for bug 2052578

Revision history for this message
Nick Rosbrook (enr0n) wrote :

I was about to comment when I saw this was uploaded. FWIW, and something to keep in mind when submitting to Debian, is that I think this could be fixed by just:

diff --git a/debian/rules b/debian/rules
index 0c9d9e1b..f4943098 100755
--- a/debian/rules
+++ b/debian/rules
@@ -7,6 +7,9 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+pie
 ifneq (,$(filter $(DEB_HOST_ARCH), armel m68k mips mipsel powerpc powerpcspe sh4))
   export DEB_LDFLAGS_MAINT_APPEND=-latomic
 endif
+ifneq (,$(filter $(DEB_HOST_ARCH), armhf))
+ export DEB_CFLAGS_MAINT_APPEND=-D_LARGEFILE64_SOURCE
+endif

 REALFILE = \
        bin/ds-logpipe.py \

I.e., just avoid the ifdeffery (which is complicated by inclusion order), and define _LARGEFILE64_SOURCE on armhf (since we know it's needed).