Comment 4 for bug 108742

Revision history for this message
Siegfried Gevatter (rainct) wrote :

Thanks for your work on this! However, there are some issues with your patch:

 - Don't delete the original (Debian) maintainer, but instead change him to XSBC-Original-Maintainer.
 - If there is a "dirs" file in the debian folder, add "usr/share/pixmaps/" to it, but don't put a mkdir on the debian/rules.
 - On the changelog, the correct syntax is "(LP: #08742)", not "lp:#108742".
 - On the .desktop file, just write "Icon=acidrip", without the extension. If you can find a .xpm, it would be good to put it in usr/share/pixmaps too.

Also, when you post a debdiff don't set the bug as "Fix Commited", set it to "Confirmed" and subscribe "ubuntu-universe-sponsors" ("ubuntu-main-sponsors", depending on the package) to it. Thanks again! :)