- test-apparmor.py is pretty intense and I see good testing performed. I went through the script and the logs, they look good. Thanks for explaining the failure, too.
- the changes, whilst being wayyyyy to many (~200 commits roughly), w/ its rationale makes sense.
- the latest build mostly looks OK. However, I did spot -
```
dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below
dpkg-gensymbols: warning: debian/libapparmor1/DEBIAN/symbols doesn't match completely debian/libapparmor1.symbols
```
Please ensure this is fixed and also run lintian prior to the upload.
- thanks for all the details, this makes it really easy to review an FFe.
Given the above points and assuming good faith (in pro-actively fixing symbol mismatch and running lintian), I think this is good to go. Thanks for your work on this.
Note - I am not an official release team member yet. I'll let them grant the final approval. :)
Hi Alex,
Thanks for filing an FFe. The quick first thing is that the ChangeLog attachment is borked. It's not readable at all. :) /gitlab. com/apparmor/ apparmor/ -/compare/ v4.0.0- alpha2. ..v3.0. 8?from_ project_ id=4484878& straight= false.
Here's a better (not the best) view - https:/
Anyway, coming to the actual review of the FFe:
- test-apparmor.py is pretty intense and I see good testing performed. I went through the script and the logs, they look good. Thanks for explaining the failure, too.
- the changes, whilst being wayyyyy to many (~200 commits roughly), w/ its rationale makes sense.
- the latest build mostly looks OK. However, I did spot - libapparmor1/ DEBIAN/ symbols doesn't match completely debian/ libapparmor1. symbols
```
dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below
dpkg-gensymbols: warning: debian/
```
Please ensure this is fixed and also run lintian prior to the upload.
- thanks for all the details, this makes it really easy to review an FFe.
Given the above points and assuming good faith (in pro-actively fixing symbol mismatch and running lintian), I think this is good to go. Thanks for your work on this.
Note - I am not an official release team member yet. I'll let them grant the final approval. :)