Comment 17 for bug 1733366

Revision history for this message
Tyler Hicks (tyhicks) wrote :

Thanks for the updated debdiffs! They look pretty good to me but I'm wondering if was intentional that True is returned when the "not os.path.exists()" checks are true but the exception handler returns False when os.readlink() throws an errno.ENOENT OSError exception? IIUC, both situations occur when the namespace files don't exist but one situation returns True and the other False.

Should both situations return True? If so, I can make those changes before sponsoring so there's no need to upload new debdiffs.