Comment 103 for bug 602934

Revision history for this message
In , Leland-audacityteam (leland-audacityteam) wrote :

(In reply to comment #89)
> Scanned the patch. Nice work with the function declaration macros, made it a
> lot more readable. And your changes are well documented.
>
> Why change several wxLogDebug() calls to wxLogMessage()? I would think that
> type of info would only be clutter to most users, and relevant only to those of
> us building Debug versions.
>
Did that because it was "hiding" what was going on when searching for the
libraries. I felt they would assist with debugging problems when users
complained about Audacity not finding the FFmpeg libraries. And since the
users get Release versions, the messages wouldn't be available.

Maybe I'm misunderstanding the reason for the log. What information in there
does the user any good? Isn't it more for the folks that are assisting users
with problems?

> I see these changes are not backward compatible, but if Gale's okay with that
> for users, I say commit this patch.

How far back do you want it to go? You can't even download any version from
the ffmpeg site before 0.5.1 and while I haven't specifically tested with that
version, why would I need to test with anything older than the version you guys
have been supplying on Buanzo's site since FFmpeg support went public?