Comment 1 for bug 1742653

Revision history for this message
Mario Sánchez Prada (mariospr) wrote : Re: chromium-browser 63+ package includes a 44MB binary only needed at build time

I believe all it's needed is to patch the debian/rules file to add `v8_context_snapshot_generator` to the TRASH list of files:
```
--- a/debian/rules 2017-12-07 08:40:06.000000000 +0000
+++ b/debian/rules 2018-01-11 10:59:39.168190995 +0000
@@ -219,7 +219,7 @@
 override_dh_install-arch: T := verify-install-integrity-dep
 override_dh_install-arch: SPACE := $(eval) $(eval)
 override_dh_install-arch: S_CR_PATH := apps/chromium/current
-override_dh_install-arch: TRASH := .deps gen obj obj.host obj.target \*.lock build.\* .landmines mksnapshot\* protoc pyproto re2c resources yasm \*.TOC product_logo_\*png gen\* lib/\* lib libvpx_obj_int_extract .ninja\* chrome-wrapper \*.breakpad.\* java_mojo dump_syms browser_test_resources ar_sample_test_driver unittests app_streaming/dev locales remoting_locales
+override_dh_install-arch: TRASH := .deps gen obj obj.host obj.target \*.lock build.\* .landmines mksnapshot\* protoc pyproto re2c resources yasm \*.TOC product_logo_\*png gen\* lib/\* lib libvpx_obj_int_extract .ninja\* chrome-wrapper \*.breakpad.\* java_mojo dump_syms browser_test_resources ar_sample_test_driver unittests app_streaming/dev locales remoting_locales v8_context_snapshot_generator
 override_dh_install-arch: debian/chromium-browser.sh
 override_dh_install-arch:
  # Two stages: Install out of source tree. Copy to packaging.
```

That said, if we're to update that TRASH list, I'd recommend adding a few more files to that list that we (Endless) found useful to reduce the size of the resulting package even more, since those are only used for building as well, and take up quite some space too (e.g. toolchain.ninja is 5 MB, gn binary is 2.5 MB...).

Thus, the full list of targets I'm proposing to add to TRASH is this:
  - v8_build_config.json
  - v8_context_snapshot_generator
  - args.gn
  - gn
  - *.ninja

This would reduce the size of the installed binary in a bit over 51MB in total, not bad :-). FWIW, we had those additional targets added to TRASH in our chromium-browser package for a while already, not sure why we didn't reported that before, sorry about that.

See attached the patch implementing this proposal